feat: add support for eslint v10 #1554
Draft
+292
−233
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change updates the version of eslint in our codebase to v10, and adds additional testing and typechecking in ci, running those steps on both v9 and v10.
michaelfaith
force-pushed
the
feat/v10
branch
from
b094f2a to
95619de
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1554 +/- ##
=======================================
Coverage 97.14% 97.14%
=======================================
Files 28 28
Lines 596 596
Branches 175 175
=======================================
Hits 579 579
Misses 2 2
Partials 15 15 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
Author
|
@JoshuaKGoldberg looks like we might be able to land this along with v8 after all. The main blocker is typescript-eslint/typescript-eslint#11952 just for our own linting usage. But as far as integrating support into the package, it was pretty straightforward. I've added an ESLint version matrix with 9 and 10 to the test and typecheck jobs to ensure we're not breaking v9 compatibility, as we work in v10. So, the branch ruleset will need updating again. After the ts-eslint bug is fixed, we can move forward with this. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
status: accepting prsOverview
This change updates the version of eslint in our codebase to v10, and adds additional testing and typechecking in ci, running those steps on both v9 and v10.